[CORE][VL] Fix protobuf memory leak in JNI_OnUnload#11532
Merged
PHILO-HE merged 1 commit intoapache:mainfrom Feb 4, 2026
Merged
[CORE][VL] Fix protobuf memory leak in JNI_OnUnload#11532PHILO-HE merged 1 commit intoapache:mainfrom
PHILO-HE merged 1 commit intoapache:mainfrom
Conversation
Add google::protobuf::ShutdownProtobufLibrary() call to properly clean up protobuf's static internal data structures when the JNI library is unloaded. This fixes memory leak reports from LeakSanitizer. Closes apache#11531
PHILO-HE
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
google::protobuf::ShutdownProtobufLibrary()call at the end ofJNI_OnUnload()to properly clean up protobuf's static internal data structures when the JNI library is unloaded.Why are the changes needed?
When running tests with LeakSanitizer enabled, a memory leak is detected:
Gluten uses protobuf for parsing
ConfigMapand Substrait plans. When the protobuf library initializes, it creates static internal data structures. According to the protobuf documentation, dynamically-loaded libraries that use protobuf must callgoogle::protobuf::ShutdownProtobufLibrary()during cleanup to free these static-duration objects when the library is unloaded.Does this PR introduce any user-facing change?
No. This only adds cleanup code that runs during library unload.
How was this patch tested?
The fix resolves the LeakSanitizer report mentioned above.
Closes #11531